Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto complete for table field triggers to early #461

Closed
gotschmarcel-ni opened this issue Mar 23, 2021 · 7 comments
Closed

Auto complete for table field triggers to early #461

gotschmarcel-ni opened this issue Mar 23, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@gotschmarcel-ni
Copy link

The auto complete for table fields triggers already when either the braces are opened or a comma is inserted after each field. It would be better to only trigger after some characters where typed or CTRL+Space was pressed. This is more common with other auto complete cases. The current solution makes it very inconvenient, because you cannot insert a new line after the open brace or after the comma w/o first cancelling the auto complete.

I attached an example project and a video demonstrating the issue.

autocomplete_trigger_early_bug

sumneko-lua-bugs.zip

Environment (please complete the following information):

  • OS: macOS
  • Client: VSCode
  • Extension Version: 1.19.1
@sumneko sumneko added the enhancement New feature or request label Mar 25, 2021
@serg3295
Copy link
Contributor

As a workaround I use Esc -> Enter

@gotschmarcel-ni
Copy link
Author

Me too, but it's annoying, because after that you also need to manually trigger the auto complete again.

@serg3295
Copy link
Contributor

Hmm...
I just use esc-enter

luasrv8

and ctrl-space works as well

@gotschmarcel-ni
Copy link
Author

Okay, it triggers again after hitting enter - you're right. It still bugs me to constantly have to hint esc.

@serg3295
Copy link
Contributor

Then what key do you suggest to complete the input of parameters from the dropdown list?

@gotschmarcel-ni
Copy link
Author

gotschmarcel-ni commented Mar 31, 2021

Usually the autocomplete should either kick in after some characters have been written or by pressing ctrl-space. No other key should by default trigger autocomplete.

@serg3295
Copy link
Contributor

serg3295 commented Mar 31, 2021

Both ctrl+space and first letter of the field works fine in autocomplete. Even if you press ctrl+enter to force to new line.

P.S. It seems I found the bug. If brackets { } are not closed, ctrl+space stops working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants