Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYM-18 - Improve tests #15

Merged
merged 27 commits into from
Jan 19, 2022
Merged

PYM-18 - Improve tests #15

merged 27 commits into from
Jan 19, 2022

Conversation

Lucino772
Copy link
Owner

@Lucino772 Lucino772 commented Jan 16, 2022

  • Improve actual tests
    • Improve tests for mojang.status
    • Improve tests for mojang.get_uuid
    • Improve tests for mojang.get_uuids
    • Improve tests for mojang.names
    • Improve tests for mojang.user
  • Add tests for mojang.account.utils.helpers
  • Add tests for authenticated user functionnalities

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2022

Codecov Report

Merging #15 (0d00887) into main (78a3449) will increase coverage by 1.64%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   39.47%   41.11%   +1.64%     
==========================================
  Files          29       29              
  Lines         950      951       +1     
  Branches      126      126              
==========================================
+ Hits          375      391      +16     
+ Misses        558      546      -12     
+ Partials       17       14       -3     
Impacted Files Coverage Δ
mojang/account/utils/helpers.py 90.00% <100.00%> (+27.93%) ⬆️
mojang/exceptions.py 85.18% <0.00%> (+3.70%) ⬆️
mojang/account/base.py 95.23% <0.00%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78a3449...0d00887. Read the comment docs.

@Lucino772 Lucino772 marked this pull request as draft January 16, 2022 16:18
@Lucino772 Lucino772 marked this pull request as ready for review January 19, 2022 17:41
@Lucino772 Lucino772 merged commit bb1edb3 into main Jan 19, 2022
@Lucino772 Lucino772 deleted the PYM-18/improve-tests branch January 19, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants