Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed old method for authentication #69

Merged
merged 5 commits into from
Mar 19, 2023

Conversation

Lucino772
Copy link
Owner

@Lucino772 Lucino772 commented Mar 19, 2023

Description

This PR removes the old method of authenticating with Mojang services. The yggdrasil method was replaced by Microsoft OAuth2 flow.

This PR also updates the documentation regarding the authentication.
This PR also adds new test for the MojangAuthenticationApp.

Type of change

  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📃 Documentation (Documentation only changes)
  • 🧪 Tests (Added missing tests)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +4.68 🎉

Comparison is base (cff160a) 74.33% compared to head (52e1e20) 79.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   74.33%   79.02%   +4.68%     
==========================================
  Files          27       25       -2     
  Lines         908      820      -88     
  Branches       83       79       -4     
==========================================
- Hits          675      648      -27     
+ Misses        209      148      -61     
  Partials       24       24              
Impacted Files Coverage Δ
mojang/api/urls.py 100.00% <ø> (ø)
mojang/api/auth/microsoft.py 100.00% <100.00%> (ø)
mojang/api/auth/models.py 79.38% <100.00%> (+11.66%) ⬆️
mojang/api/structures.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lucino772 Lucino772 merged commit d5e7be1 into main Mar 19, 2023
@Lucino772 Lucino772 deleted the refactor/remove-old-auth branch March 19, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant