New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MustNewConstMetric to collect proxy metrics #112

Open

Lusitaniae opened this issue Sep 20, 2021 · 0 comments

Labels

enhancement help wanted

Owner

Lusitaniae commented Sep 20, 2021

I think that this fix is not correct, we should instead use a MustNewConstMetric and collect it on every scrape.

The current approach is fragile because if 2 prometheus scrape at the same time, they will get hazardous results.

Originally posted by @roidelapluie in #111 (comment)

Lusitaniae added enhancement help wanted labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment