Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate possibilities for further *Def simplifications #17

Open
Lusito opened this issue Nov 9, 2020 · 0 comments
Open

Evaluate possibilities for further *Def simplifications #17

Lusito opened this issue Nov 9, 2020 · 0 comments
Labels
Cleanup good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Lusito
Copy link
Owner

Lusito commented Nov 9, 2020

In flyovers port, all *Def ports had one interface and one class defined.
In some cases, I was able to make this just an interface, making creation of objects even simpler by just passing an object rather than creating it and adjust its settings. b2FixtureDef is one of those.

There are however other places, where this has not been done yet. Partially, because in some of these cases, inheritance is part of the equation.

Evaluate what can be done to further improve this.

An added benefit might be that we could allow third-party joints if we only required an interface for the JointDef.

@Lusito Lusito added Cleanup good first issue Good for newcomers help wanted Extra attention is needed labels Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant