Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPLACE_ICON / FAVICON is broken. #184

Open
lazarusA opened this issue Oct 8, 2024 · 3 comments
Open

REPLACE_ICON / FAVICON is broken. #184

lazarusA opened this issue Oct 8, 2024 · 3 comments

Comments

@lazarusA
Copy link
Collaborator

lazarusA commented Oct 8, 2024

We should rename all the REPLACing ones to the task they are actually doing.
@asinghvi17
Copy link
Collaborator

Is that one not explicitly named though?

Or did a change in the template break it?

@lazarusA
Copy link
Collaborator Author

lazarusA commented Oct 8, 2024

DocumenterVitepress.jl/template/src/.vitepress/config.mts

Line 30 in 865cd35

logo: 'REPLACE_ME_DOCUMENTER_VITEPRESS',

we didn't change anything here.

@asinghvi17
Copy link
Collaborator

ah yeah, problem is that this will break users who have custom config.mts

I didn't really think this through when I wrote it :(...maybe we can release a breaking version of DV, and force people to update?

Or support multiple "replacement formats" based on some heuristic check. Both are ugly but I don't see a better option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lazarusA @asinghvi17