Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher level recurrent layers #972

Open
MartinuzziFrancesco opened this issue Oct 7, 2024 · 2 comments
Open

Higher level recurrent layers #972

MartinuzziFrancesco opened this issue Oct 7, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@MartinuzziFrancesco
Copy link
Member

Hi! While it is relatively straightforward to implement higher level constructions like LSTM and GRU it's also nice to have a layer provided by the library like PyTorch does, having details like bidirectionality and dropout taken care of.
Are there any plans to include this in Lux as well?

Thanks!

@avik-pal avik-pal added the good first issue Good for newcomers label Oct 7, 2024
@avik-pal
Copy link
Member

avik-pal commented Oct 7, 2024

Sure I will accept PRs for this. The general layers policy we use is:

  1. If a layer is present in Pytorch or Flax, we can have it in Lux (except some cases like Conv2D which is just Conv and such)
  2. Boltz.jl is a better place for any other layers.

In this particular case, LSTM should return a AbstractLuxWrapperLayer containing the model (which can be written using Chain I think) and we just do a custom show method for nicer printing.

@MartinuzziFrancesco
Copy link
Member Author

Ok sounds good to me, I'll see if I can get something going!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants