Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add real links to albums #1704

Closed
Tragen opened this issue Jan 10, 2023 · 3 comments · Fixed by #2035
Closed

[Enhancement] Add real links to albums #1704

Tragen opened this issue Jan 10, 2023 · 3 comments · Fixed by #2035
Labels
enhancement New feature or request

Comments

@Tragen
Copy link

Tragen commented Jan 10, 2023

Go to https://lycheeorg.github.io/demo/ and hover with the mouse over the different albums.
There is no link so you cannot open the album with a middle click in a new tab.
The same problem is with any picture inside an album.

@ildyria ildyria added enhancement New feature or request Livewire Front-End labels Jan 10, 2023
@ildyria
Copy link
Member

ildyria commented Jan 10, 2023

Will have to wait for a revamp of the front-end.

@vasilevich
Copy link

I think, to support such a thing, first of all the project has to change the way it does links,

instead of using # with codes which might work but is clumsy and i think not even indexable properly,
eg myphotosite.com/#1234567
should just be something like myphotosite.com/1234567 or myphotosite.com/album/1234567
it should work with the browser history api.
a website that works like that for example is github.com , when you click things, it just performs history.push with the new url
and then things can have custom links more easily
maybe the blade templating engine has some good routing support for this way too, in conjunction with the browser history api

@ildyria
Copy link
Member

ildyria commented Jan 11, 2023

Yes... That is why I am exploring the Livewire option. Unfortunately, I don't have a lot of time IRL to work on Lychee with my current work + other hobbies...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants