Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add more permission levels to album permissions #1905

Closed
Rendili opened this issue Jun 26, 2023 · 3 comments
Closed

[Enhancement] Add more permission levels to album permissions #1905

Rendili opened this issue Jun 26, 2023 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@Rendili
Copy link

Rendili commented Jun 26, 2023

It would be really useful to have a bit more control over who can do what in albums, more granularity of permissions a person can have in an album would be great.

The main one for me is giving the ability for someone who is not an owner of an album to upload photos to the album.

This would be a great addition in the scenario where someone could create a new album at an event where family / friends were also attending and everyone could upload their photos to the same album to share with everyone else.

The following permission levels would be really good, each one as a tickbox in the GUI (except maybe for Owner):

  • Owner (as today, the owner of the album, can modify everything about the album and edit permissions)
  • Upload (only available to a person once View has been granted and gives the ability to upload photos to the album)
  • Edit / Delete (only available to a person once View has been granted and gives the ability to edit photos and delete photos)
  • View (gives only the ability to view the photos in the album, but not edit (not able to edit tags, description, title, rotate photo, etc.), delete or upload)
@Rendili Rendili changed the title Add more permission levels to album permissions [Enhancement] Add more permission levels to album permissions Jun 26, 2023
@ildyria
Copy link
Member

ildyria commented Jun 26, 2023

Hi, thank you for the idea.
This is actually already on our radar:

See: #1462
And:

class AccessPermission extends Model
{
use UTCBasedTimes;
use HasAttributesPatch;
use ThrowsConsistentExceptions;
protected $casts = [
'created_at' => 'datetime',
'updated_at' => 'datetime',
APC::USER_ID => 'integer',
APC::IS_LINK_REQUIRED => 'boolean',
APC::GRANTS_FULL_PHOTO_ACCESS => 'boolean',
APC::GRANTS_DOWNLOAD => 'boolean',
APC::GRANTS_UPLOAD => 'boolean',
APC::GRANTS_EDIT => 'boolean',
APC::GRANTS_DELETE => 'boolean',
];

@ildyria ildyria closed this as completed Jun 26, 2023
@ildyria ildyria added the duplicate This issue or pull request already exists label Jun 26, 2023
@Rendili
Copy link
Author

Rendili commented Jun 26, 2023

excellent, thanks for the link, that is pretty much covers everything.

sorry for the duplicate, my search of existing didn't include those key words.

if there is anything i can help with let me know, adding an upload permission at an album level would enable me to use this much more extensively

@ildyria
Copy link
Member

ildyria commented Jun 26, 2023

Redesigning the sharing menu would be an improvement.
We don't have the API end point to modify the access rights yet (still need to be implemented, you can give a try at it :) ).

Some of the access rights integrations are already there. e.g.
https://github.com/LycheeOrg/Lychee/blob/master/app/Policies/AlbumPolicy.php#L171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants