Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add configurable option to have about-photo panel open by default #653

Closed
danshilm opened this issue Jul 7, 2020 · 2 comments
Labels
enhancement New feature or request Project for volunteers The team has no plans to work on it (e.g. lack of time) but an external contribution is accepted

Comments

@danshilm
Copy link

danshilm commented Jul 7, 2020

This is something that I find myself always opening manually and which I believe would be especially useful for people with wide enough screens. Of course, I believe it shouldn't apply to smaller screens like mobile phones (and tablets?) since the picture would be barely visible.

However, this might be something that seems over the top, so a good compromise imo would be to make the about-panel's appearance persist throughout a user session. That way if I open it when I view my first picture after I sign in, it's open by default when I go to view another picture.

I'm actually gonna go dive in the codebase and see if I can make a PR for this if you guys have no issues with it.

@ildyria ildyria added enhancement New feature or request Project for volunteers The team has no plans to work on it (e.g. lack of time) but an external contribution is accepted labels Jul 9, 2020
@ildyria
Copy link
Member

ildyria commented Jul 9, 2020

I'm actually gonna go dive in the codebase and see if I can make a PR for this if you guys have no issues with it.

I like that comment. 😃

If you have any questions, feel free to drop by on gitter: https://gitter.im/LycheeOrg/Lobby

@LouisVallat
Copy link

A new mechanism has been introduced in PR LycheeOrg/Lychee-front#276, which should fix this issue. With this PR, the sidebar's state/visibility is remembered during the whole browsing session.

Thanks for bringing this enhancement idea and helping improve Lychee 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Project for volunteers The team has no plans to work on it (e.g. lack of time) but an external contribution is accepted
Projects
None yet
Development

No branches or pull requests

3 participants