Albums or photos are incorrectly set after migration from Lychee v3.x

[elvisef]

Detailed description of the problem [REQUIRED]

I have some albums set to be: public, hidden, and protected with pass (with Lychee v3).
But it does not work properly, without changes.

If I click "unpublish" and "publish" again, it works as expected with certain settings.
But without it, v3 settings for albums does not work.
The first effect, after loading certaing public hidden album v3 is that there is no pass popup, just all images are shown.

Next time, I tried to disable "original images" or set password (pass was set in v3 version, here there was no indication of that setting - just like the pass was not set), images disappeared completely.

Steps to reproduce the issue

Steps to reproduce the behavior:

1. Go to album that was set with settings, ex. pass, public, hidden etc.. in v3 version of Lychee
2. Do nothing - just copy the URL
3. Go to ex. incognito window
4. Load URL - see what happens..

Screenshots
database - sample album, set with Lychee v3, I did not changed anything here:

photos from this album:

Output of the diagnostics [REQUIRED]

Not required I think.

Browser and system

OS: Win7 PRO
Browser: Firefox 85.0.2 (64 bity)

[kamil4]

Looking at the source code:

Lychee/database/migrations/2018_08_15_102039_move_albums.php

Lines 25 to 33 in 3274d9a

	DB::table('albums')->insert([
	'id' => $id,
	'title' => $result->title,
	'description' => $result->description,
	'public' => $result->public,
	'visible_hidden' => $result->visible,
	'license' => $result->license ?? 'none',
	'created_at' => date('Y-m-d H:i:s', $result->sysstamp),
	]);

I can confirm that passwords aren't being copied between the v3 and v4 albums. I'm not sure why -- perhaps the password encoding schemes are incompatible between the two? @ildyria?

[kamil4]

It looks like they both use bcrypt...

[kamil4]

OK, this will get fixed, but it won't affect you since your albums have already been migrated. What I mean by that is that you would have to start from v3 again to benefit from the fix.

[elvisef]

Alright, I understand. I will need to do it manually : )
I hope the "save" button will work out of the box.

Edit: Just saving using a button did not help. It did not, because the "secured" option is disabled when entering album options (v3 migrated and secured with password album). So I need to enter a new password and then save.

[ildyria]

It seems we need to copy an additional data :(

[kamil4]

I'm not sure what the issue is?

We are talking about albums that were migrated from v3 before #928 was merged, correct? In that case the passwords weren't copied, so indeed in order to re-enable the passwords one needs to check the Password protected box and then enter the password in the input field that appears. This is how it's supposed to work.

[elvisef]

Yes. I just wrote it in order to remember to let know other users in the FAQ or wherever, if they have problems as in my case.
I have nothing else to say here though : )