-
-
Notifications
You must be signed in to change notification settings - Fork 493
Fix: Linux AppImage update handling for in-app updating. #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @NeuralFault, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves the long-standing issue of in-app self-updating for Linux AppImages. Previously, the application could not successfully replace itself due to AppImage's isolation. The new logic introduces a sophisticated shell script-based approach to manage the replacement and relaunch of the AppImage, ensuring a smooth and automated update experience for users, with a clear fallback mechanism in case of failure. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a mechanism for handling in-app updates for the Linux AppImage version of the application. The approach of using a shell script to replace the running AppImage is sound. However, I've identified a critical security vulnerability related to command injection in the script generation, which must be addressed. I've also provided suggestions to improve the script's robustness, maintainability of the code, and the clarity of error messages for a better user experience. Please review the detailed comments.
…able handling and error messaging
|
ready for merge |
Fixing support for seamless self-updating of the application when running as a Linux AppImage. The new logic handles replacing the running AppImage with the updated version, including a fallback and user notification if the automatic update fails. Currently, due to nature of AppImage security and isolation characteristics, Stability Matrix's in-app updater is not able to successfully copy over the new version over the currently existing AppImage. Causing SM to restart as the old version again and not the updated version. This required the user to manually copy the new version out of the '.StabilityMatrixUpdate' hidden directory and overwrite the old one with it.
Linux AppImage self-update support:
UpdateViewModel.csto detect when running as an AppImage and, after downloading an update, generate and execute a shell script that waits for the app to exit, replaces the old AppImage with the new one, sets executable permissions, and relaunches the updated AppImage in the background.