Skip to content

Conversation

@NeuralFault
Copy link
Contributor

Fixing support for seamless self-updating of the application when running as a Linux AppImage. The new logic handles replacing the running AppImage with the updated version, including a fallback and user notification if the automatic update fails. Currently, due to nature of AppImage security and isolation characteristics, Stability Matrix's in-app updater is not able to successfully copy over the new version over the currently existing AppImage. Causing SM to restart as the old version again and not the updated version. This required the user to manually copy the new version out of the '.StabilityMatrixUpdate' hidden directory and overwrite the old one with it.

Linux AppImage self-update support:

  • Added logic in UpdateViewModel.cs to detect when running as an AppImage and, after downloading an update, generate and execute a shell script that waits for the app to exit, replaces the old AppImage with the new one, sets executable permissions, and relaunches the updated AppImage in the background.
  • If the script execution fails, logs the error and presents a markdown dialog to the user explaining the manual update steps required, then falls back to the standard update process.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @NeuralFault, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves the long-standing issue of in-app self-updating for Linux AppImages. Previously, the application could not successfully replace itself due to AppImage's isolation. The new logic introduces a sophisticated shell script-based approach to manage the replacement and relaunch of the AppImage, ensuring a smooth and automated update experience for users, with a clear fallback mechanism in case of failure.

Highlights

  • Automated AppImage Updates: Implemented a new mechanism for Linux AppImages to self-update seamlessly by replacing the running application with the updated version, addressing previous limitations due to AppImage security characteristics.
  • Shell Script Execution: Introduced a dynamically generated shell script (update_script.sh) that waits for the current application process to exit, moves the newly downloaded AppImage over the old one, sets executable permissions, and then relaunches the updated application in the background.
  • Fallback and User Notification: Added robust error handling for cases where the update script execution fails. If the script cannot run, an error is logged, and a markdown dialog is presented to the user, explaining the manual update steps required, before falling back to the standard update process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a mechanism for handling in-app updates for the Linux AppImage version of the application. The approach of using a shell script to replace the running AppImage is sound. However, I've identified a critical security vulnerability related to command injection in the script generation, which must be addressed. I've also provided suggestions to improve the script's robustness, maintainability of the code, and the clarity of error messages for a better user experience. Please review the detailed comments.

@NeuralFault
Copy link
Contributor Author

ready for merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant