Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background white when loading immediately after launching #21

Closed
jacobmischka opened this issue Jan 23, 2022 · 3 comments
Closed

Background white when loading immediately after launching #21

jacobmischka opened this issue Jan 23, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@jacobmischka
Copy link

jacobmischka commented Jan 23, 2022

As of 0.4.0, the main window is always black on white before initialization is finished. Prior to this version, it would immediately launch with my colorscheme. It does load eventually, so this isn't a huge deal, but it's a bit jarring to see the bright white window for a few ms now.

Kooha-01-23-2022-04-34-59.mp4

Technical information (please complete the following information):

  • OS: Arch Linux
  • Neovim version: 0.6.1
  • Neovim-Gtk build version: 0.4.0 (976693e)
@jacobmischka
Copy link
Author

jacobmischka commented Jan 23, 2022

Hm. I could have sworn that the colors were correct immediately, but maybe I was wrong. I'll have to investigate more on my other computer tomorrow which I haven't updated yet, because I can't seem to find a commit now that behaves as I remember.

At the very least, the default change from dark background to light in f0d9019 is noticeable.

There's not necessarily a "correct" assumption between light and dark as a default, though dark seems to have been the previous behavior and seems more likely for neovim users.

@Lyude
Copy link
Owner

Lyude commented Jan 23, 2022

Hm. I could have sworn that the colors were correct immediately, but maybe I was wrong. I'll have to investigate more on my other computer tomorrow which I haven't updated yet, because I can't seem to find a commit now that behaves as I remember.

At the very least, the default change from dark background to light in f0d9019 is noticeable.

There's not necessarily a "correct" assumption between light and dark as a default, though dark seems to have been the previous behavior and seems more likely for neovim users.

Mhh - I didn't even think about this when changing it, as I generally run with solarized. It would probably be good to make sure as well that it's actually still on the default color when initializing and that the autocmd we execute when starting up to read the initial background state hasn't been executed yet. With that being said though, I'm happy to switch the default back to dark - I think most people would prefer that, and it would be better to maintain the previous behavior we had. I should note though, I've been considering replacing the loading screen when I start coming up with a DrawingArea replacement for #8, so in the future we may simply do something like display a spinner against the system theme's background and not use the nvim colors there.

@Lyude Lyude added the bug Something isn't working label Jan 23, 2022
@Lyude Lyude self-assigned this Jan 23, 2022
@Lyude Lyude closed this as completed in 7fe1bc5 Jan 23, 2022
@jacobmischka
Copy link
Author

jacobmischka commented Jan 24, 2022

👍

I could have sworn that the colors were correct immediately, but maybe I was wrong. I'll have to investigate more on my other computer tomorrow which I haven't updated yet, because I can't seem to find a commit now that behaves as I remember.

I was misremembering (vividly!) because it was just white-on-black before. Appreciate the swap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants