Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoneFilter broken #128

Closed
webstey opened this issue Jan 18, 2024 · 1 comment
Closed

NoneFilter broken #128

webstey opened this issue Jan 18, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@webstey
Copy link

webstey commented Jan 18, 2024

NoneFilter was not filtering anything out for me. I changed 'False' to 'None' in this line and it works now. It looks like you were providing 'False' as the default to getattr, but then checking for 'None'. I may be missing some intended behaviour that my change breaks, but this worked for me.

if all(getattr(msg, attr, False) is not None for attr in self.attrs):

@M0r13n M0r13n added the bug Something isn't working label Jan 20, 2024
@M0r13n M0r13n self-assigned this Jan 20, 2024
@M0r13n
Copy link
Owner

M0r13n commented Jan 20, 2024

@webstey You are right. That's a rather dumb bug on my part. Thank you for bringing this up. :)

Fixed in version 2.6.1

@M0r13n M0r13n closed this as completed Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants