Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of stream detection missing #14

Open
sp5wwp opened this issue Jun 24, 2024 · 3 comments
Open

End of stream detection missing #14

sp5wwp opened this issue Jun 24, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@sp5wwp
Copy link
Member

sp5wwp commented Jun 24, 2024

Since our implementation doesn't use tags, there is no way the encoder block could tell there's no more data to encode. This results in missing End of Transmission frame. I suspect the Frame Number of the last frame doesn't get its MSB set to 1 either.

@sp5wwp sp5wwp added the bug Something isn't working label Jun 24, 2024
@lwvmobile
Copy link

I don't suppose there is a way to implement a PTT button in GNURadio blocks that can signal that sort of thing, or if you did if it would require significant code changes to implement.

@sp5wwp
Copy link
Member Author

sp5wwp commented Jul 3, 2024

PTT signal is not needed. It is enough that the data source would mark the end of the data stream with a tag.

@jmfriedt
Copy link
Contributor

See jmfriedt@0b5e5e4 for an attempt at adding message passing to send an end-of-transmission information to the transmitter block. The GNU Radio flowgraph does not seem to be terminated when the block returns -1 though as would be expected from https://lists.gnu.org/archive/html/discuss-gnuradio/2017-01/msg00034.html whose outcome is not clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants