Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs containing underscores are being italicized #86

Open
pacu opened this issue Mar 13, 2019 · 3 comments
Open

URLs containing underscores are being italicized #86

pacu opened this issue Mar 13, 2019 · 3 comments

Comments

@pacu
Copy link

pacu commented Mar 13, 2019

Marky-Mark information

  • Marky-Mark version: 9.1.0 (seen since 6.0)
  • MarkDownConfiguration: AttributedString

Describe the bug

URLs containing underscores or other markdown characters are being formatted (italicized in this case) when they shouldn't

I'm using the Example App to create this issue.

Used markdown text

<https://test.com/adsf_qwer_dg_dfg_swert_dfg>

[https://test.com/adsf_qwer_dg_dfg_swert_dfg]

https://test.com/adsf_qwer_dg_dfg_swert_dfg

Screenshots

image

@pacu
Copy link
Author

pacu commented Mar 13, 2019

note that GitHub parses this correctly

https://test.com/adsf_qwer_dg_dfg_swert_dfg

[https://test.com/adsf_qwer_dg_dfg_swert_dfg]

https://test.com/adsf_qwer_dg_dfg_swert_dfg

@khoogheem
Copy link

khoogheem commented Sep 19, 2019

This also effects image links as well..
But it makes it more crazy as it will put the text from where the underscore starts under the image as if it is extra text.

for example you have ![User Content. Description unavailable](https://res.cloudinary.com/xxxxx/image/fetch/q_auto,ar_4:3,c_fill,g_faces:auto/https://xxxxxxxxx/sites/bnppm7.ap2s.fr/files/styles/generic_article_seo_thumb/public/20181104_RPM_CL_2418_web_0.jpg?itok=5CdRIYKj)<space><space>\n
you get the Image.. but right under it you get the text:
g_faces:auto/https://xxxxxxxxxx/sites/bnppm7.ap2s.fr/files/styles/generic_article_seo_thumb/public/20181104_RPM_CL_2418_web_0.jpg?itok=5CdRIYKj)

@khoogheem
Copy link

I should probably add that that only seems to happen if it hits the InlineImage Rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants