Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frequency could crash with an explanation #9

Open
micah-prime opened this issue Mar 14, 2024 · 0 comments
Open

Frequency could crash with an explanation #9

micah-prime opened this issue Mar 14, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@micah-prime
Copy link
Contributor

  • metevents version: 0.3.0
  • Python version: 3.9
  • Operating System: Mac OS

Description

StormEvents.find will crash if there is a fully missing timestep (not NAN). This should crash, but we should add an error describing why. Currently when determine_frequency is called, it returns None in this case.

We could change the default behavior of determine_frequency to raise a RunTimeError, but have a kwarg into the function to not raise an error if the user wants to get the None returned
@micah-prime micah-prime added the enhancement New feature or request label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@micah-prime