Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Create XPrivacy subdir to hold exported rules and keyfile to avoid cluttering up root of sdcard. #27

Closed
famewolf opened this issue Jun 16, 2013 · 14 comments

Comments

@famewolf
Copy link

Since you can now export settings AND you have a pro key file consider creating a XPrivacy subdir off root folder of sd card and keeping everything in there? Eventually you might add other files etc to the folder without cluttering the root of the sd card up. Backups could be modded to just backup the whole dir which would also potentially keep backups of the person's keyfile.

@famewolf
Copy link
Author

Also consider allowing the user to specify both where to import and export the file. This would allow them to specify their own subdir which for example might be one that auto sync's with dropbox or other fileshare hosts.

@famewolf
Copy link
Author

When user is choosing where to save the file please allow them to choose what to name the file as well...this will allow multiple backups and also saving a file for each device since some devices may have apps specific to them even if the user has multiple devices.

@M66B
Copy link
Owner

M66B commented Jun 29, 2013

Android does not have a file chooser dialog.
Putting the license file into the root folder is the most user friendly solution.

@M66B M66B closed this as completed Jun 29, 2013
@M66B
Copy link
Owner

M66B commented Jun 29, 2013

I have seen these all, but I don't want a custom file chooser.

@famewolf
Copy link
Author

The main one I presented just overrides the onCreateDialog to handle the filepath and options to cancel etc If you don't like their solutions you could always code your own using that.

In any case you could still move the pro key AND the backups into a .XPrivacy subfolder which is what the original request was instead of cancelling the whole thing.

@M66B M66B reopened this Jul 3, 2013
@M66B
Copy link
Owner

M66B commented Jul 3, 2013

I will check for the license file in both the root folder and the .xprivacy folder.
Export/import file also go to / come from the .xprivacy folder.

@famewolf
Copy link
Author

famewolf commented Jul 3, 2013

Just clarifying under linux filename rules (I'm not sure if android follows them) directories beginning with a period are hidden by default when browsing from a file manager....so if you want it visable just lose the . and use /sdcard/XPrivacy/

@M66B
Copy link
Owner

M66B commented Jul 3, 2013

A hidden folder seems a good solution in this case to me.

@M66B
Copy link
Owner

M66B commented Jul 3, 2013

Will be fixed in the next release.

@M66B M66B closed this as completed Jul 3, 2013
@pylerSM
Copy link
Contributor

pylerSM commented Jul 4, 2013

"Android does not have a file chooser dialog."
Yes, but you can call file managers to do that job.
you can use this code:
Intent pickFile = new Intent(Intent.ACTION_GET_CONTENT);
pickFile.setType("file/*");
startActivityForResult(pickFile,1);

@M66B
Copy link
Owner

M66B commented Jul 4, 2013

But does each and every device have a file manager?

@famewolf
Copy link
Author

famewolf commented Jul 4, 2013

Is that the code for oi file manager? It has a freely available api but then xprivacy would have to require oi file manager be installed....not a good idea. I can tell you several factory rom's I had did not have any kind of file manager....because they don't want you sideloading apps.

@pylerSM
Copy link
Contributor

pylerSM commented Jul 5, 2013

I think that people which have xposed & xprivacy installed they have file managers for sure...

And, you can still add AlertDialog with text input so user can write path to file

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants