New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to correct the step of u+1 #4

Open

beblueblue opened this issue Jun 25, 2021 · 1 comment · May be fixed by #6

beblueblue commented Jun 25, 2021 •

edited

Loading

GAMES101-HW/hw3/main.cpp

Line 367 in b53fe64

    
           float dV = kh * kn * ( payload.texture->getColor(u+1, v+1.0f/h).norm() - payload.texture->getColor(u, v).norm() );

float dV = kh * kn * ( payload.texture->getColor(u+1.0f / w, v+1.0f/h).norm() - payload.texture->getColor(u, v).norm() );

Thank you very much for sharing the code, it helped me a lot!

Owner

MARMOTatZJU commented Feb 22, 2022

@beblueblue Thanks for this correction! Would you mind launching a Pull Request for this correction? Many thanks in advance!

beblueblue linked a pull request

that will close this issue

fix(HW3): correct the step of dV #6

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment