Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform the UI when we can't satisfy the HTTP Request and change the name of RouteQueryMessage to RouteQueryRequest. #774

Open
czarte opened this issue Feb 20, 2024 · 0 comments
Labels
hardenning Getting a feature working stronger

Comments

@czarte
Copy link
Collaborator

czarte commented Feb 20, 2024

In actual state, we do not inform UI when we can't find the Route to host. In ServerImpersonator we have 3 errors we can receive from the neighborhood, and we transform them into a simple web page that we send back to the browser.

The node/src/proxy_server/mod.rs handle_route_failure is the right place, where we want to inform UI about the RouteQueryRequest failure. That means we want to add a UIGateway subscriber into struct ProxyServer.

RouteQueryMessage now returns Option. Changing the return type would be beneficial in the way, that we will be able to write stronger tests for the RouteQuery Requests in case the Neighborhood fails to find a route.
RouteQueryMessage would probably be better to rename to RouteQueryRequest, which is more comprehensive in the matter of what the functionality is doing. It corresponds with our other Actix Messages, where we use Request and Response for particular data.

@czarte czarte changed the title Change the return type of RouteQueryMessage. Inform the UI when we can't find the Route to host and change the return type of RouteQueryMessage. Feb 21, 2024
@czarte czarte changed the title Inform the UI when we can't find the Route to host and change the return type of RouteQueryMessage. Inform the UI when we can't satisfy the HTTP Request and change the name of RouteQueryMessage to RouteQueryRequest. Feb 21, 2024
@kauri-hero kauri-hero added the hardenning Getting a feature working stronger label Mar 10, 2024
@kauri-hero kauri-hero moved this to Ready for Development in MASQ Node v2 May 19, 2024
@github-project-automation github-project-automation bot moved this to Ready for Development in MASQNode Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hardenning Getting a feature working stronger
Projects
Status: 🔖 Ready
Status: Ready for Development
Development

No branches or pull requests

2 participants