You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In actual state, we do not inform UI when we can't find the Route to host. In ServerImpersonator we have 3 errors we can receive from the neighborhood, and we transform them into a simple web page that we send back to the browser.
The node/src/proxy_server/mod.rshandle_route_failure is the right place, where we want to inform UI about the RouteQueryRequest failure. That means we want to add a UIGateway subscriber into struct ProxyServer.
RouteQueryMessage now returns Option. Changing the return type would be beneficial in the way, that we will be able to write stronger tests for the RouteQuery Requests in case the Neighborhood fails to find a route.
RouteQueryMessage would probably be better to rename to RouteQueryRequest, which is more comprehensive in the matter of what the functionality is doing. It corresponds with our other Actix Messages, where we use Request and Response for particular data.
The text was updated successfully, but these errors were encountered:
czarte
changed the title
Change the return type of RouteQueryMessage.
Inform the UI when we can't find the Route to host and change the return type of RouteQueryMessage.
Feb 21, 2024
czarte
changed the title
Inform the UI when we can't find the Route to host and change the return type of RouteQueryMessage.
Inform the UI when we can't satisfy the HTTP Request and change the name of RouteQueryMessage to RouteQueryRequest.
Feb 21, 2024
In actual state, we do not inform UI when we can't find the Route to host. In ServerImpersonator we have 3 errors we can receive from the neighborhood, and we transform them into a simple web page that we send back to the browser.
The
node/src/proxy_server/mod.rs
handle_route_failure
is the right place, where we want to inform UI about the RouteQueryRequest failure. That means we want to add a UIGateway subscriber intostruct ProxyServer
.RouteQueryMessage now returns Option. Changing the return type would be beneficial in the way, that we will be able to write stronger tests for the RouteQuery Requests in case the Neighborhood fails to find a route.
RouteQueryMessage would probably be better to rename to RouteQueryRequest, which is more comprehensive in the matter of what the functionality is doing. It corresponds with our other Actix Messages, where we use Request and Response for particular data.
The text was updated successfully, but these errors were encountered: