Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make hole2 conda-forge package a dependency #55

Open
orbeckst opened this issue Feb 25, 2024 · 5 comments
Open

make hole2 conda-forge package a dependency #55

orbeckst opened this issue Feb 25, 2024 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation packaging PyPi and conda-forge

Comments

@orbeckst
Copy link
Member

We created a conda-forge package for hole2 (Linux and OSX) when we started working on mdahole2. However, the mdahole2 cf package does not install hole2 itself. It's up to the user to do so (and even that is not clear, see #25 ).

It would be much more convenient if mdahole2 installed hole2 via a dependency on the hole2 package.

Given that the conda-forge package for hole2 only supports Linux and OSX, our mdahole2 package can only depend on hole2 for these two archs.

@orbeckst
Copy link
Member Author

@IAlibay @fiona-naughton is it possible to make conda package dependencies dependent on the architecture?

@IAlibay
Copy link
Member

IAlibay commented Feb 26, 2024

@orbeckst there are two packages mdahole2 (which should install hole2) and mdahole2-base (which doesn't install hole2). Is that not working as intended?

@orbeckst
Copy link
Member Author

orbeckst commented Feb 26, 2024 via email

@IAlibay
Copy link
Member

IAlibay commented Feb 26, 2024

Yeah agreed on the docs.

Re: architecture dependent packages - just quickly wanted to say that yes that's a thing you can do technically. It's not the approach taken here, but it's doable.

@orbeckst orbeckst added the documentation Improvements or additions to documentation label Mar 27, 2024
@orbeckst orbeckst self-assigned this Mar 27, 2024
@orbeckst
Copy link
Member Author

I'll update the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation packaging PyPi and conda-forge
Projects
None yet
Development

No branches or pull requests

2 participants