Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs specify incorrect memory order for Timestep #3675

Closed
hmacdope opened this issue May 24, 2022 · 3 comments
Closed

Docs specify incorrect memory order for Timestep #3675

hmacdope opened this issue May 24, 2022 · 3 comments
Assignees
@hmacdope
Labels
Component-Docs

Comments

@hmacdope
Copy link
Member

hmacdope commented May 24, 2022 •
edited
Loading

Expected behavior

The docs specify the memory order of `timestep._pos' correctly to be "C".

Actual behavior

The docs here

specifies

_pos  of dtype float32 of shape (n_atoms, 3) and internal FORTRAN order, holding the raw cartesian coordinates ...

Where 'FORTRAN' should be replaced by 'C'
@hmacdope hmacdope self-assigned this May 24, 2022
@orbeckst
Copy link
Member

Can you add to the issue report what the correct answer is?

@hmacdope
Copy link
Member Author

Done, apologies should have left more detail.

@hmacdope
Copy link
Member Author

This was fixed in #3683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmacdope hmacdope

Labels
Component-Docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orbeckst @hmacdope