-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert removal of MDAnalysis.topology.guessers
in 2.x branch
#4751
Milestone
Comments
cc @MDAnalysis/coredevs - it's unclear to me why we were ok with doing this API break. I remember querying it at the time but I don't remember the response I had. |
8 tasks
+1 to copying over and deprecating -- sounds like the best course of action to me. IMO it would have been ideal to import the methods from the new location, but making them part of DefaultGuesser made that pretty hard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #4748
The Guessers PR removed
MDAnalysis.topology.guessers
, however it is being actively used downstream, see pytim for an example of this.Since this is a major API break, we shouldn't be including it in the 2.x release, but rather deprecate that code to be removed in 3.x.
The text was updated successfully, but these errors were encountered: