Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sourceTEs option #485

Closed
tsalo opened this issue Dec 11, 2019 · 3 comments · Fixed by #493
Closed

Remove sourceTEs option #485

tsalo opened this issue Dec 11, 2019 · 3 comments · Fixed by #493
Labels
decomposition issues related to decomposition methods discussion issues that still need to be discussed

Comments

@tsalo
Copy link
Member

tsalo commented Dec 11, 2019

Summary

In a discussion that I am unable to locate, I recall someone saying that maPCA would be incompatible with running PCA on z-concatenated data (i.e., using anything other than optimally combined data with the sourceTEs option). Given that we were never able to find a satisfactory rationale or use-case for the argument (see #203), I think that we should remove it.

Next Steps

  1. Remove --sourceTEs from tedana CLI, workflow function, and PCA functions.
@tsalo tsalo added discussion issues that still need to be discussed decomposition issues related to decomposition methods labels Dec 11, 2019
@eurunuela
Copy link
Collaborator

As far as I can tell, maPCA is not compatible with —sourceTEs. I guess it could be implemented in the feature but I personally do not know how atm.

@tsalo
Copy link
Member Author

tsalo commented Dec 12, 2019

@eurunuela Thanks! It's good to have that on record from someone more familiar with that code than me. I don't think there's much benefit (if any) to supporting sourceTEs, even if maPCA was compatible with it already, since there's no real conceptual difference between the different options.

@eurunuela
Copy link
Collaborator

Totally agree on that @tsalo. I don't see any benefits to supporting sourceTEs either but I'm not very familiar with the rest of the code anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decomposition issues related to decomposition methods discussion issues that still need to be discussed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants