You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In a discussion that I am unable to locate, I recall someone saying that maPCA would be incompatible with running PCA on z-concatenated data (i.e., using anything other than optimally combined data with the sourceTEs option). Given that we were never able to find a satisfactory rationale or use-case for the argument (see #203), I think that we should remove it.
Next Steps
Remove --sourceTEs from tedana CLI, workflow function, and PCA functions.
The text was updated successfully, but these errors were encountered:
@eurunuela Thanks! It's good to have that on record from someone more familiar with that code than me. I don't think there's much benefit (if any) to supporting sourceTEs, even if maPCA was compatible with it already, since there's no real conceptual difference between the different options.
Summary
In a discussion that I am unable to locate, I recall someone saying that maPCA would be incompatible with running PCA on z-concatenated data (i.e., using anything other than optimally combined data with the
sourceTEs
option). Given that we were never able to find a satisfactory rationale or use-case for the argument (see #203), I think that we should remove it.Next Steps
--sourceTEs
from tedana CLI, workflow function, and PCA functions.The text was updated successfully, but these errors were encountered: