Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current Master Failing CI #517

Closed
jbteves opened this issue Jan 3, 2020 · 2 comments · Fixed by #518
Closed

Current Master Failing CI #517

jbteves opened this issue Jan 3, 2020 · 2 comments · Fixed by #518
Labels
bug issues describing a bug or error found in the project testing issues related to improving testing in the project

Comments

@jbteves
Copy link
Collaborator

jbteves commented Jan 3, 2020

Summary

For some reason in 4a56876 we're failing CI, which is bizarre since it only changed the license type. According to the failed report view here the 4-echo test generated mismatched outputs, where we expect s0v.nii and two other files to be generated; however, they are not.

Next Steps

@tsalo @emdupre @rmarkello any thoughts on what's happening?

@tsalo
Copy link
Member

tsalo commented Jan 4, 2020

The error message is misleading. s0v.nii is not missing- it's just that no BOLD components are being detected so none of the denoised files are written out. I don't know what's causing the issue, however something similar is also impacting #358.

@tsalo tsalo added bug issues describing a bug or error found in the project testing issues related to improving testing in the project labels Jan 4, 2020
@dowdlelt
Copy link
Collaborator

dowdlelt commented Jan 7, 2020

Looking through the artifacts, its finding plenty of components, its just ignoring almost all of them:
image
image

Its odd how 'close' the kappa and rho values are.
Not sure how this could be related to the license change at all. Really doesn't seem like it could be. The mask and components all still look 'good'.

EDIT:
This is insanity: Component 1 from successful test and failed test are effectively the exact same, but kappa and rho values changed...
image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issues describing a bug or error found in the project testing issues related to improving testing in the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants