Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t2smap_workflow does not use explicit mask #544

Closed
tsalo opened this issue Mar 2, 2020 · 0 comments · Fixed by #545
Closed

t2smap_workflow does not use explicit mask #544

tsalo opened this issue Mar 2, 2020 · 0 comments · Fixed by #545
Labels
bug issues describing a bug or error found in the project good first issue issues that we think are good for new contributors. Equivalent to "very low" effort.

Comments

@tsalo
Copy link
Member

tsalo commented Mar 2, 2020

Summary

Although our logger says that the explicit mask is used, it doesn't look like this was ever implemented.

if mask is None:
LGR.info('Computing adaptive mask')
else:
LGR.info('Using user-defined mask')
mask, masksum = utils.make_adaptive_mask(catd, getsum=True)

Additional Detail

I think this serves as a good example of why #488 is important. t2smap_workflow gets very little attention, and as a result may be overlooked in terms of features added to tedana_workflow.

I noticed this bug while working on #513 with @cjl2007's data.

Next Steps

  1. Add mask parameter to make_adaptive_mask call, as is done in tedana_workflow.
mask, masksum = utils.make_adaptive_mask(catd, mask=mask, getsum=True) 
@tsalo tsalo added bug issues describing a bug or error found in the project good first issue issues that we think are good for new contributors. Equivalent to "very low" effort. labels Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issues describing a bug or error found in the project good first issue issues that we think are good for new contributors. Equivalent to "very low" effort.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant