Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restarted decompositions add duplicate text to reports #738

Closed
tsalo opened this issue Jun 17, 2021 · 0 comments · Fixed by #743
Closed

Restarted decompositions add duplicate text to reports #738

tsalo opened this issue Jun 17, 2021 · 0 comments · Fixed by #743
Labels
bug issues describing a bug or error found in the project impact: medium Improves code/documentation functionality for some users priority: low issues that are not urgent reports issues related to boilerplate generation or visual reports

Comments

@tsalo
Copy link
Member

tsalo commented Jun 17, 2021

Summary

When no BOLD components are found and a new ICA is automatically performed (a feature added in #663), a number of lines are written to the text report again. See below for an example screenshot from our four-echo test:

Screen Shot 2021-06-17 at 12 16 22 PM

Next Steps

We could probably add a series of if statements and a new parameter (report) to relevant functions, so that those lines are only logged on the first pass. There might be other good solutions though.
@tsalo tsalo added bug issues describing a bug or error found in the project priority: low issues that are not urgent impact: medium Improves code/documentation functionality for some users labels Jun 17, 2021
@tsalo tsalo changed the title Restarted decompositions added duplicate text to reports Restarted decompositions add duplicate text to reports Jun 20, 2021
@tsalo tsalo added the reports issues related to boilerplate generation or visual reports label Jul 6, 2021
@tsalo tsalo mentioned this issue Jul 7, 2021
Merged
@tsalo tsalo closed this as completed in #743 Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug issues describing a bug or error found in the project impact: medium Improves code/documentation functionality for some users priority: low issues that are not urgent reports issues related to boilerplate generation or visual reports
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] Disable report logging during ICA restart loop tsalo/tedana
1 participant
@tsalo