Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include prefix in report, log, and figures #901

Closed
tsalo opened this issue Nov 19, 2022 · 2 comments · Fixed by #963
Closed

Include prefix in report, log, and figures #901

tsalo opened this issue Nov 19, 2022 · 2 comments · Fixed by #963
Labels
breaking change WIll make a non-trivial change to outputs effort: medium Theoretically <40h total work enhancement issues describing possible enhancements to the project priority: medium Should get addressed soon

Comments

@tsalo
Copy link
Member

tsalo commented Nov 19, 2022

Summary

I've noticed that our current output structure doesn't work well if you want to run multiple tasks/runs from the same subject/session in the same output directory (i..e, a BIDS derivatives-like structure). If we ensure that the files without prefixes have them, then it should work fine.

@tsalo tsalo added enhancement issues describing possible enhancements to the project breaking change WIll make a non-trivial change to outputs labels Nov 19, 2022
@handwerkerd handwerkerd added priority: medium Should get addressed soon effort: medium Theoretically <40h total work labels Jun 27, 2023
@handwerkerd
Copy link
Member

Would the idea be to add a prefix to every single png file or just to the figure's directory and everything in the tedana output directory?

Also, you marked this as a breaking change. If the default option is no prefix, then I don't think this would be a breaking change.

@tsalo
Copy link
Member Author

tsalo commented Jun 28, 2023

Would the idea be to add a prefix to every single png file or just to the figure's directory and everything in the tedana output directory?

I planned to add the prefix to each figure, like how fMRIPrep does it.

Also, you marked this as a breaking change. If the default option is no prefix, then I don't think this would be a breaking change.

That's a good point. In that case, it's just a typical enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change WIll make a non-trivial change to outputs effort: medium Theoretically <40h total work enhancement issues describing possible enhancements to the project priority: medium Should get addressed soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants