-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility issue with Angular 8/TS 3.5.3 #10
Comments
Hey @rushvora, yes my recent push was to get up to angular 10 - would you mind trying the previous |
Hey @METACEO, the same issue still persists. I went through the history of package.json, and even v0.0.1 has Angular 9 as the peer dependency, not Angular 8. I believe the version of TS used from Angular 9 onwards works with the above code, which is causing issues with Angular 8/TS 3.5.3. The latest version is working fine with the Angular 8 app after adding |
@rushvora I'd hate for you to have to turn on |
@METACEO Yes, absolutely! That would be amazing. |
I was using your library and while compiling, came across these errors —
A bit of googling tells me this is because there is a TS version mismatch. I assume you wrote this for Angular 10, while I am using Angular 8.
I worked around this by setting
"skipLibCheck": true
in mytsconfig.json
, which I believe just disables type checking for libraries used in the app.Just wanted to bring this to your attention.. maybe add this piece of information to your readme?
I used windowRef and it works great.. so I am assuming I won't have any issues with using this in an Angular 8 app.
Thanks!
The text was updated successfully, but these errors were encountered: