Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue with Angular 8/TS 3.5.3 #10

Open
rushvora opened this issue Sep 13, 2020 · 4 comments
Open

Compatibility issue with Angular 8/TS 3.5.3 #10

rushvora opened this issue Sep 13, 2020 · 4 comments

Comments

@rushvora
Copy link

I was using your library and while compiling, came across these errors —

Screenshot 2020-09-13 at 16 46 41

A bit of googling tells me this is because there is a TS version mismatch. I assume you wrote this for Angular 10, while I am using Angular 8.
I worked around this by setting "skipLibCheck": true in my tsconfig.json, which I believe just disables type checking for libraries used in the app.

Just wanted to bring this to your attention.. maybe add this piece of information to your readme?

I used windowRef and it works great.. so I am assuming I won't have any issues with using this in an Angular 8 app.

Thanks!

@METACEO
Copy link
Owner

METACEO commented Sep 15, 2020

Hey @rushvora, yes my recent push was to get up to angular 10 - would you mind trying the previous ng-refs package version (0.3.2) with your Angular 8 project?

https://www.npmjs.com/package/ng-refs/v/0.3.2

@rushvora
Copy link
Author

Hey @METACEO, the same issue still persists. I went through the history of package.json, and even v0.0.1 has Angular 9 as the peer dependency, not Angular 8. I believe the version of TS used from Angular 9 onwards works with the above code, which is causing issues with Angular 8/TS 3.5.3.

The latest version is working fine with the Angular 8 app after adding "skipLibCheck": true to tsconfig.json, so that's what I am doing for now, till we upgrade all our Angular projects to v10.

@METACEO
Copy link
Owner

METACEO commented Sep 24, 2020

@rushvora I'd hate for you to have to turn on skipLibCheck - if I were to branch off a past commit and publish a separate version for ng8, would you use it?

@rushvora
Copy link
Author

@METACEO Yes, absolutely! That would be amazing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants