Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface lag when selecting zip files #29

Closed
justalike opened this issue Apr 9, 2024 · 5 comments
Closed

Interface lag when selecting zip files #29

justalike opened this issue Apr 9, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@justalike
Copy link

justalike commented Apr 9, 2024

Hey! I've noticed that when pointer is at archives (zip files in my case) it freezes the spf while calculating archived metadata.
If you have a large archive with lots and lots of small files there it will freeze the app for quite a long time.

In my case 450 mb archive with about 1mil files would take around 9-12 seconds to process.
Archives with many files but about 10-15mb take 1-2 seconds.

moreover, inputs are not blocked but queued when you try to move pointer up/down while it calculates.

@yorukot yorukot added the bug Something isn't working label Apr 9, 2024
@yorukot
Copy link
Owner

yorukot commented Apr 9, 2024

I can confirm this
This need to be fix!

@justalike
Copy link
Author

I guess the fix could be non-blocking input, and / or trigger extracting metadata with delay (while pointer stays on the file for longer than 100-250 ms)
just thoughts.

@yorukot
Copy link
Owner

yorukot commented Apr 9, 2024

Yes, I will put the part of getting Metadata into the thread, and after getting the data, Send it back to the main program.

@AnshumanNeon
Copy link
Contributor

The performance can be improved by immediately finding only those metadata that are shown immediately. Then the rest can be lazy loaded if user goes to the metadata panel. If not, they won't be loaded.
My thoughts only, idk how to implement but lazy loading is pretty popular these days and effective too.

@yorukot
Copy link
Owner

yorukot commented Apr 10, 2024

@justalike
I just fix it in here!
If you can please check this update fix the problem and close the issue

Thank you so much for report this bug!!

@yorukot yorukot closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants