Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting some guidelines for testing #76

Open
hugofluhr opened this issue Aug 22, 2023 · 2 comments
Open

Setting some guidelines for testing #76

hugofluhr opened this issue Aug 22, 2023 · 2 comments
Labels
Discussion Discussion of a concept or implementation, needs to stay open Documentation This issue or PR is about the documentation

Comments

@hugofluhr
Copy link
Collaborator

Hi,

I think it would be nice to have some guidelines for writing test functions. For example, I am thinking that we could decide on where to use equality or all_close tests.

Maybe we can come up with some rules and put them somewhere in the documentation.
@hugofluhr hugofluhr added Documentation This issue or PR is about the documentation Discussion Discussion of a concept or implementation, needs to stay open labels Aug 22, 2023
@smoia
Copy link
Collaborator

smoia commented Aug 22, 2023

That is completely true - I don't have a good example nor idea in mind though. We can record what we're doing and how we're adjusting stuff in documentations - but we can also keep this issue in order to record questions and answers and decisions!

@mscheltienne
Copy link
Collaborator

Feel free to ping me on github on a PR with questions about testing/testing design choices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion Discussion of a concept or implementation, needs to stay open Documentation This issue or PR is about the documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smoia @hugofluhr @mscheltienne