Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fetch_file with a proper 'dataset' module using pooch #90

Open
mscheltienne opened this issue Mar 12, 2024 · 1 comment
Open

Replace fetch_file with a proper 'dataset' module using pooch #90

mscheltienne opened this issue Mar 12, 2024 · 1 comment
Labels
Testing This is for testing features, writing tests or producing testing code

Comments

@mscheltienne
Copy link
Collaborator

tests use datasets downloaded through a custom fetch_file function using urllib. pooch should be used instead, and can be integrated as a separate dataset module to allow:

  • testing dataset for tests
  • sample datasets for tutorial/reproducibility

Example in MNE-Python, or simpler version in MNE-LSL: https://github.com/mne-tools/mne-lsl/tree/main/mne_lsl/datasets
@mscheltienne mscheltienne added Enhancement New feature or request and removed Enhancement New feature or request labels Mar 12, 2024
@smoia smoia added the Testing This is for testing features, writing tests or producing testing code label Mar 12, 2024
@smoia
Copy link
Collaborator

smoia commented Mar 12, 2024

Sure, go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Testing This is for testing features, writing tests or producing testing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smoia @mscheltienne