You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now we have the Record class with a huge number of attributes in the top level object. These attributes are varied, fall into many categories, and become very hard to keep track of.
I also find it rather awkward that there is no separate 'header' or 'metadata' type of object. ie. rdheader and rdrecord both return the same type of object.
Initial idea:
RecordInfo class for storing all the header data. Includes record and signal specification fields, and comments. rdheader will create this type.
Same Record class for WFDB records. The info attribute will be a RecordInfo object.
Having the top level p_signal, d_signal attributes is not my favorite, but I feel like it's rather pointless to have another object to capture these fields.
Open to suggestions.
The text was updated successfully, but these errors were encountered:
RecordInfo class for storing all the header data. Includes record and signal specification fields, and comments. rdheader will create this type.
It would be good to chat about this. I'm getting myself slightly confused about how these classes (e.g. RecordInfo for header information and Record for data) would relate to the files themselves (e.g. x.hea for headers and x.dat for data).
Having the top level p_signal, d_signal attributes is not my favorite, but I feel like it's rather pointless to have another object to capture these fields.
Side note, but it would be nice if these variables had friendlier names. p_signal, d_signal, e_p_signal, and e_d_signal are pretty opaque.
Right now we have the
Record
class with a huge number of attributes in the top level object. These attributes are varied, fall into many categories, and become very hard to keep track of.I also find it rather awkward that there is no separate 'header' or 'metadata' type of object. ie.
rdheader
andrdrecord
both return the same type of object.Initial idea:
RecordInfo
class for storing all the header data. Includes record and signal specification fields, and comments.rdheader
will create this type.Record
class for WFDB records. Theinfo
attribute will be aRecordInfo
object.Having the top level
p_signal
,d_signal
attributes is not my favorite, but I feel like it's rather pointless to have another object to capture these fields.Open to suggestions.
The text was updated successfully, but these errors were encountered: