Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change approach for allowing seg_name and seg_len to be lists #516

Open
briangow opened this issue Nov 8, 2024 · 0 comments
Open

Change approach for allowing seg_name and seg_len to be lists #516

briangow opened this issue Nov 8, 2024 · 0 comments

Comments

@briangow
Copy link
Collaborator

briangow commented Nov 8, 2024

In #514 an update was made to allow seg_name and seg_len to be lists. This is needed for writing a MultiSegmentRecord.

@bemoody , suggested an alternate approach:

But I think what we really want is, rather than changing the types in SEGMENT_SPECS, we want to add "seg_name" and "seg_len" to LIST_FIELDS (wfdb/io/record.py, line 1675.)

This issue is being opened to track implementing this alternate approach.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@briangow