Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting ideas #6

Open
jswoboda opened this issue Aug 5, 2021 · 9 comments
Open

Plotting ideas #6

jswoboda opened this issue Aug 5, 2021 · 9 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jswoboda
Copy link
Member

jswoboda commented Aug 5, 2021

Ideas to improve presentation of plots

  • Put un-shifted hydrogen line on spectrum plots as a marker or a toggle that can turn on and off.
  • Add a plots tab with more images running and have the following
    • N-point scan plot
    • Waterfall plot of spectrum.
  • Change the way the plots update on the dashboard to be driven by updates in the data and not regular timed updates.
@jswoboda jswoboda added enhancement New feature or request help wanted Extra attention is needed labels Aug 5, 2021
@jswoboda jswoboda changed the title More plotting ideas Plotting ideas Aug 5, 2021
@sstoneb
Copy link

sstoneb commented Aug 9, 2021

I'd definitely like to see your last bullet point there--updating the plots only when there's new data instead of on a fixed time interval. With the default config at least, it seems like data only comes in every third or fourth refresh.

A little "Last update: X seconds ago" field somewhere might be nice, too.

@imyxh
Copy link
Contributor

imyxh commented Apr 2, 2023

My professor remarked that it would be nice to have some way to subtract the background continuum signal to better look at the shifted hydrogen emission. Or is that already a feature that I just missed?

Also, thanks for the lovely software :)

EDIT: of course this is a feature; it's built into the calibration!

@imyxh
Copy link
Contributor

imyxh commented Sep 28, 2023

So, we're using this software at our school for an intro course (thanks for making it!) but first we could really use:

  • an option to show LSRK velocities on the plot
  • a continuous integration mode

I'd love to work on either or both of these but I also don't want to conflict with any of your previous work (I think some LSRK conversion is in progress?). Do you have some pointers about how best to integrate these two features into the current codebase?

For the continuous integration part, one option is to make a separate gnuradio flowgraph that outputs a continuous average of the spectrum to ZMQ, though we could also just do that averaging in python using the current flowgraph. I'm tempted to do the latter method, just multiplying the previous spectrum by (N+1)/N and the new one by 1/N. What do you think?

@jswoboda
Copy link
Member Author

jswoboda commented Oct 1, 2023

Hi, we do actually label the LSRK velocity but only for the 0 Doppler. It's not in the plot its on the left hand side of the dashboard. I wasn't certain if this would be useful for the students to derive it themselves. I can add a feature to switch out the frequency offset ticks with the LSRK velocity.

The continuous integration is something I'd like to add. I'll see if I can do something simple where you can just turn in on in a button and the plot just holds over the current one.

@imyxh
Copy link
Contributor

imyxh commented Oct 1, 2023

I'll have some time this semester to work on this. Which of those two would you like help on first, if any?

@jswoboda
Copy link
Member Author

jswoboda commented Oct 6, 2023

Hi, I'm fine if you want to update some of the plots with the frequency dependent vlsr on the spectrum and add the "continuous integration" feature. The line of sight velocity is probably the best things to start with. We use the term vlsr (velocity in the local standard of rest). I perform the base calculation using astropy, you would just be adding the apparent Doppler shift.
Please make the continuous integration feature something you can turn on and off from the dashboard. I will note, I just did a major pull request and will be integrating work from another student to allow the SRT to work as a transit telescope. So just watch out that this doesn't interfere with your work.

@AlexKurek
Copy link

AlexKurek commented Apr 21, 2024

I have added waterfall plot in my fork:
AlexKurek@d8ea8c1.
Screenshot from 2024-04-21 12-21-03

@imyxh
Copy link
Contributor

imyxh commented Apr 22, 2024

For what it's worth the "vvo" branch of my fork also has continuous integration and VLSR plotting support. Meant to send a PR but never got around to it.

@AlexKurek
Copy link

@imyxh I was able to run your fork like so:

git clone -b vvo https://github.com/imyxh/srt-py
conda create -y -n vvosrt python=3.11.9
conda activate vvosrt
conda config --env --add channels conda-forge
conda config --env --set channel_priority strict

conda install -y numpy scipy rtl-sdr soapysdr soapysdr-module-rtlsdr gnuradio-core gnuradio-zeromq gnuradio-osmosdr digital_rf pyzmq pyserial astropy yamale dash dash-bootstrap-components dash-core-components plotly pandas waitress

conda develop .
cd srt-py/
python bin/srt_runner.py --config_dir=/home/alex/srtpy-config_oryginal

I see the new PLOTTING menu and its working, but the figures never show up. It stays like so:

Screenshot 2024-05-04 at 10-34-58 SRT Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants