Skip to content

Commit ce3f749

Browse files
committed
refactor(DDD): URLs are now seperated
Follow django phylosophy (trailing /)
1 parent 08b9e55 commit ce3f749

File tree

4 files changed

+32
-26
lines changed

4 files changed

+32
-26
lines changed

blog/presentation/api/post_api.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def get_user_profile(cls, request, user_name):
7575
def get_param(request, param_name, default_value):
7676
try:
7777
param = int(request.GET.get(param_name))
78-
except ValueError:
78+
except:
7979
param = default_value
8080

8181
return param

blog/presentation/api/urls.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
from blog.presentation.api.post_api import PostAPI
44

55
urlpatterns = [
6-
path('index', PostAPI.get_latest_posts),
6+
path('index/', PostAPI.get_latest_posts),
77

8-
path('post/<int:post_id>', PostAPI.get_post),
8+
path('post/<int:post_id>/', PostAPI.get_post),
99

10-
path('@<str:user_name>', PostAPI.get_user_profile),
10+
path('@<str:user_name>/', PostAPI.get_user_profile),
1111
]

blog/presentation/views/urls.py

+26
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
from django.urls import path
2+
3+
from blog.presentation.views.homepage_view import HomepageView
4+
from blog.presentation.views.post_view import PostView
5+
from blog.presentation.views.profile_view import ProfileView
6+
7+
from blog.presentation.api.comment_service import CommentService
8+
from blog.presentation.api.like_service import LikeService
9+
10+
urlpatterns = [
11+
path('', HomepageView.index, name='home'),
12+
path('<int:page>/', HomepageView.index),
13+
14+
path('post/<int:post_id>/', PostView.post, name='post'),
15+
path('post/<int:post_id>/<int:page>/', PostView.post),
16+
path('post/<int:post_id>/liked', LikeService.liked),
17+
path('post/<int:post_id>/comment', CommentService.comment),
18+
path('post/<int:post_id>/comment/<int:comm_id>/rm', CommentService.comment_delete),
19+
20+
path('new/', HomepageView.index, name='new'),
21+
path('create/', PostView.create_post, name='create'),
22+
23+
24+
path('@<str:user_name>/', ProfileView.user_profile, name='user_profile'),
25+
path('@<str:user_name>/<str:activity_type>/', ProfileView.user_profile, name='user_profile_type'),
26+
]

djangoProject/urls.py

+2-22
Original file line numberDiff line numberDiff line change
@@ -15,39 +15,19 @@
1515
"""
1616
from django.contrib import admin
1717
from django.urls import path, include
18-
from django.conf.urls import handler404
1918
from django.conf.urls.static import static
2019

21-
from blog.presentation.api.like_service import LikeService as liked_view
2220
from blog.presentation.views.homepage_view import HomepageView as homepage_view
2321
from blog.presentation.views.registration_view import RegistrationView as registration_view
24-
from blog.presentation.api.comment_service import CommentService as comment
25-
from blog.presentation.views.profile_view import ProfileView as profile_view
26-
from blog.presentation.views.post_view import PostView as post_view
2722

2823
from djangoProject import settings
2924

3025
urlpatterns = [
3126
path('admin/', admin.site.urls),
3227
path("me/", include("django.contrib.auth.urls")),
33-
path("me/register", registration_view.register_page, name='register'),
28+
path("me/register/", registration_view.register_page, name='register'),
3429

35-
# ex: /blog/
36-
path('', homepage_view.index, name='home'),
37-
path('<int:page>', homepage_view.index),
38-
path('<int:page>/', homepage_view.index),
39-
path('post/<int:post_id>/', post_view.post, name='post'),
40-
path('post/<int:post_id>/<int:page>/', post_view.post),
41-
path('post/<int:post_id>/liked', liked_view.liked),
42-
path('post/<int:post_id>/comment', comment.comment),
43-
path('post/<int:post_id>/comment/<int:comm_id>/rm', comment.comment_delete),
44-
45-
path('new/', homepage_view.index, name='new'),
46-
path('create/', post_view.create_post, name='create'),
47-
48-
49-
path('@<str:user_name>/', profile_view.user_profile, name='user_profile'),
50-
path('@<str:user_name>/<str:activity_type>/', profile_view.user_profile, name='user_profile_type'),
30+
path('', include('blog.presentation.views.urls')),
5131

5232
path('api/', include('blog.presentation.api.urls')),
5333

0 commit comments

Comments
 (0)