You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, sample_kernels only supports sampling kernels from entirely within the provided timeseries (or batch of multiple timeseries) and has a max_center_offset kwarg that restricts the sampling range wrt the center of the timeseries. However
For most timeseries that would want to use this functionality, the end of the timeseries is more interesting, since e.g. for waveforms this is where the coalescence lies (or at least should lie)
Even with that in mind, this functionality probably isn't in the purview of sample_kernels at all: if you want to restrict the range of the timeseries that you sample, restrict them (or pad with 0s where necessary) before passing them into sample_kernels, then just let it sample uniformly.
It's probably worth having a KernelSampler class that constructs the necessary index tensors up front, and then drops the max_center_offset functionality. Downstream use cases like #71 and #72 can then do whatever slicing/padding is appropriate for their use case.
The text was updated successfully, but these errors were encountered:
Right now,
sample_kernels
only supports sampling kernels from entirely within the provided timeseries (or batch of multiple timeseries) and has amax_center_offset
kwarg that restricts the sampling range wrt the center of the timeseries. Howeversample_kernels
at all: if you want to restrict the range of the timeseries that you sample, restrict them (or pad with 0s where necessary) before passing them intosample_kernels
, then just let it sample uniformly.It's probably worth having a
KernelSampler
class that constructs the necessary index tensors up front, and then drops themax_center_offset
functionality. Downstream use cases like #71 and #72 can then do whatever slicing/padding is appropriate for their use case.The text was updated successfully, but these errors were encountered: