Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with Codacy #55

Open
lauragustafson opened this issue May 10, 2018 · 4 comments
Open

Integrate with Codacy #55

lauragustafson opened this issue May 10, 2018 · 4 comments
Labels
internal improvement Improvements that do not change the public API

Comments

@lauragustafson
Copy link
Contributor

Integrate with Codacy for automatic analysis/commenting on PR's for code quality and style. Would reduce a lot of the work in analyzing PR's.

@micahjsmith micahjsmith added the internal improvement Improvements that do not change the public API label May 12, 2018
@kveerama
Copy link
Contributor

@micahjsmith @csala any comments?

@micahjsmith
Copy link
Contributor

is this a general workflow tool, or are you targeting it specifically for people who contribute new tuners?

@csala
Copy link
Contributor

csala commented May 16, 2018

It sounds interesting as an additional quality metric, and I would say that at least it's worth a try.
However, I wouldn't expect it to be able to really replace the PR reviews.

Another option would be to give something like pylint a try, but it can become a bit annoying if we don't tweak the configuration to fit our our coding style preferences (maybe this also stands for codacy!)

@lauragustafson
Copy link
Contributor Author

@micahjsmith It would be a general workflow tool, but we are using it to specifically target the contributions.

@csala It wouldn't completely replace the PR reviews but would help lessen the back and forth in contribution PR's. Essentially, we could wait to review a contribution-related PR (or really any) until after codacy accepts the code. At this point the code should be in pretty good shape, so reviewing a PR would take much less work. Also the default codacy settings do require a bit of tweaking in the configuration for some of our preferences (eg turning off some of the security-related checks). I integrated it into my fork of BTB and there weren't that many settings that needed tweaking and I found the comments/reviews pretty useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal improvement Improvements that do not change the public API
Projects
None yet
Development

No branches or pull requests

4 participants