Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid default metric name #82

Closed
ChengFR opened this issue Feb 17, 2021 · 0 comments · Fixed by #83
Closed

Invalid default metric name #82

ChengFR opened this issue Feb 17, 2021 · 0 comments · Fixed by #83
Assignees
@ChengFR
Labels
bug Something isn't working
Milestone
0.1.2

Comments

@ChengFR
Copy link
Collaborator

ChengFR commented Feb 17, 2021

The default metric name f1 in benchmark.py is not consistent with metric options in the modeler, which should be F1 Macro.

Cardea/cardea/benchmark/benchmark.py

Lines 329 to 330 in e0461e2

scores = modeler.evaluate(features, target,
tune=optimize, scoring='f1', metrics=metrics, max_evals=10)

@ChengFR ChengFR added the bug Something isn't working label Feb 17, 2021
@ChengFR ChengFR self-assigned this Feb 17, 2021
@ChengFR ChengFR mentioned this issue Feb 17, 2021
Merged
@sarahmish sarahmish added this to the 0.1.2 milestone Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChengFR ChengFR

Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.2
Development

Successfully merging a pull request may close this issue.

Fix benchmark MLBazaar/Cardea
2 participants
@ChengFR @sarahmish