Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in batch duration calculation: duration can be longer than the render that's observed in the timeline #124

Open
taneliang opened this issue Aug 10, 2020 · 0 comments
Labels
bug Something isn't working importance: 1 - must have Must be implemented for the issue's phase to be complete phase: 2 - iteration Iterations on our MVP urgency: 3 - within 2 weeks work type: investigation A task that primarily involves digging into a particular problem

Comments

@taneliang
Copy link
Member

taneliang commented Aug 10, 2020

From #123:

I suspect there's a bug in our batch duration calculation, because the zoom to method often zooms to an empty space. This is not a bug in the zooming: the view is zoomed to a range that matches the batch duration displayed in the tooltip.

image

Perhaps caused by the lack of render cancelled marks (MLH-Fellowship/react#30)?

Update 19 Aug

Seems like getBatchRange just sets the range's end time to the start time of the next batch. Is this intentional/correct?

for (i; i < measures.length; i++) {
const measure = measures[i];
stopTime = measure.timestamp;
if (measure.batchUID !== batchUID) {
break;
}
}

@taneliang taneliang added bug Something isn't working phase: 2 - iteration Iterations on our MVP importance: 1 - must have Must be implemented for the issue's phase to be complete work type: investigation A task that primarily involves digging into a particular problem urgency: 3 - within 2 weeks labels Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working importance: 1 - must have Must be implemented for the issue's phase to be complete phase: 2 - iteration Iterations on our MVP urgency: 3 - within 2 weeks work type: investigation A task that primarily involves digging into a particular problem
Projects
None yet
Development

No branches or pull requests

1 participant