Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major bug in landice/antarctica/mesh_gen #729

Closed
trhille opened this issue Nov 13, 2023 · 5 comments · Fixed by #730
Closed

Major bug in landice/antarctica/mesh_gen #729

trhille opened this issue Nov 13, 2023 · 5 comments · Fixed by #730
Labels
bug Something isn't working land ice

Comments

@trhille
Copy link
Collaborator

trhille commented Nov 13, 2023

When running the landice/antarctica/mesh_gen case using default config settings, the mesh that is created is unusable:
image

Thanks to @cwsmith for catching this!

@trhille trhille added bug Something isn't working land ice labels Nov 13, 2023
@xylar
Copy link
Collaborator

xylar commented Nov 13, 2023

Looks fine to me!

@trhille
Copy link
Collaborator Author

trhille commented Nov 13, 2023

My initial thought was that that this was caused by the new cell culler, but the problem persists even when I checkout commit 51e65a5e342aa34bec97fb5478be7b75abc8be6e and use dev_compass_1.2.0-alpha.5. In the testing section of the mesh generation refactor PR, I reported that the mesh was identical to the code before the refactor. However, there are numerous clean-up commits after that testing that could be responsible for the issue. That points to insufficient testing on my part.

@trhille
Copy link
Collaborator Author

trhille commented Nov 13, 2023

Further investigation reveals that antarctica_8km_2020_10_20_floodFillMask.nc contains only isolated pockets of ice, which indicates an issue with the flood fill.

@trhille
Copy link
Collaborator Author

trhille commented Nov 13, 2023

Testing indicates that this was introduced by 8b327bd.

@xylar
Copy link
Collaborator

xylar commented Nov 13, 2023

@trhille, very sorry about that! I don't understand why it's a problem but let's revert it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working land ice
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants