Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve destructive bookmark views #1346

Closed
alastair opened this issue Jul 15, 2019 · 1 comment · Fixed by #1822
Closed

Improve destructive bookmark views #1346

alastair opened this issue Jul 15, 2019 · 1 comment · Fixed by #1822
Labels
Bug Something that doesn't work as it should starter

Comments

@alastair
Copy link
Member

The views to delete bookmarks and bookmark categories perform the delete on a GET request. We should update this to have a confirmation page and to use POST or DELETE to do the deletion.
@alastair alastair added the Bug Something that doesn't work as it should label Jul 15, 2019
@alastair alastair added this to the Current milestone Jul 15, 2019
@ffont
Copy link
Member

ffont commented Nov 30, 2023

After the new UI, the deletion confirmation is done with a JS modal, but the delete request should also be changed to be a POST instead of GET.

@ffont ffont removed this from the Current milestone Dec 13, 2023
@alastair alastair mentioned this issue Jan 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something that doesn't work as it should starter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require bookmark delete operations to use POST MTG/freesound
2 participants
@alastair @ffont