Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaos Machine Item Recovery #534

Open
nitoygo opened this issue Nov 24, 2024 · 3 comments
Open

Chaos Machine Item Recovery #534

nitoygo opened this issue Nov 24, 2024 · 3 comments
Labels

Comments

@nitoygo
Copy link
Contributor

nitoygo commented Nov 24, 2024

Describe the bug
Items left in chaos machine can not be recovered when game crashes or on disconnection

To Reproduce
Steps to reproduce the behavior:

  1. Place items for chaos mixing
  2. // Disconnect or crash happens
  3. Reconnect
  4. // Items are lost

Expected behavior
Server has a way or an option for the player to recover items left unintentionally in the chaos machine

@nitoygo nitoygo added the bug label Nov 24, 2024
@sven-n
Copy link
Member

sven-n commented Nov 24, 2024

I think the best would be to handle this like the trade. When a disconnect happens, the items should be moved back to the original position before saving the account.

@nitoygo
Copy link
Contributor Author

nitoygo commented Nov 24, 2024

Agreed. However, for the case where the mix already happened, it might need special handling (?). No idea yet what happens to the persistence of that new/upgraded/downgraded item.

@sven-n
Copy link
Member

sven-n commented Nov 24, 2024

Yea, that needs some extra logic for sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants