Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted process: Credits are auto-scrolling while invisible #95

Closed
hsandt opened this issue May 31, 2024 · 0 comments · Fixed by #99
Closed

Unwanted process: Credits are auto-scrolling while invisible #95

hsandt opened this issue May 31, 2024 · 0 comments · Fixed by #99
Assignees
Labels
bug Something isn't working

Comments

@hsandt
Copy link

hsandt commented May 31, 2024

Currently Credits._process just runs in the wild, even when Credits are not visible (e.g. when touching nothing on the main menu).

I noticed this when logging scrolling value (I'm working on a version that stores float scrolling to support slower scrolling, esp. important on lores pixel art games where 1px/s is very fast).

Credits should either manually return from _process when not visible, or we set its process mode to DISABLED entirely when not visible.

Ex of code hotfix:

func _process(_delta):
	if Engine.is_editor_hint():
		return
	# LOCAL FIX by hsandt to avoid scrolling Credits while invisible,
	# in the background
	if not visible:
		return
	# do stuff...
@Maaack Maaack self-assigned this Jun 6, 2024
@Maaack Maaack added the bug Something isn't working label Jun 6, 2024
@Maaack Maaack linked a pull request Jun 6, 2024 that will close this issue
@Maaack Maaack closed this as completed in #99 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants