Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expired link contained in the document page #1383

Closed
burugaria7 opened this issue Jul 2, 2023 · 3 comments
Closed

Expired link contained in the document page #1383

burugaria7 opened this issue Jul 2, 2023 · 3 comments

Comments

@burugaria7
Copy link
Contributor

Hello. I found a expired link in the documentation.

The link included in the tips in section 4 Bag-of-words of the algorithm on the documentation page has expired.

page containing expired link:
https://maartengr.github.io/BERTopic/algorithm/algorithm.html#3-cluster-documents

expired link:
https://maartengr.github.io/BERTopic/getting_started/countvectorizer/countvectorizer.html

@MaartenGr
Copy link
Owner

Thanks for sharing this! If you want, a PR is definitely appreciated. Otherwise, I'll make sure to fix it myself.

@burugaria7 burugaria7 reopened this Jul 6, 2023
@burugaria7
Copy link
Contributor Author

Thanks for sharing this! If you want, a PR is definitely appreciated. Otherwise, I'll make sure to fix it myself.

My pleasure. I would very much like to create a PR. By the way, should the link to replace it link to the Vectorizers page (https://maartengr.github.io/BERTopic/getting_started/vectorizers/vectorizers.html) or to the CountVectorizer within that page (https://maartengr.github.io/BERTopic/getting_started/vectorizers/vectorizers.html#countvectorizer)?

@MaartenGr
Copy link
Owner

Thanks, the first option would be best I think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants