Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Handle RediSearch version specific feature #6

Closed
MacFJA opened this issue May 2, 2021 · 1 comment
Closed

Feature: Handle RediSearch version specific feature #6

MacFJA opened this issue May 2, 2021 · 1 comment
Milestone

Comments

@MacFJA
Copy link
Owner

MacFJA commented May 2, 2021

Add a feature to detect RediSearch version to handle RediSearch capability depending on the version.

Some RediSearch features are not available in all versions of RediSearch 2.x
To prevent sending incompatible request to RediSearch server, it would be create to catch those incompatibilities at the lib level.


To get the RediSearch version the command INFO Modules with a bit of filtering should give all the needed information, or a generic configuration added to all objects


This protective behavior should be deactivable, as it can cost (especially the RediSearch version requesting in Redis)

@MacFJA MacFJA added this to the 2.0.0 milestone Jul 23, 2021
@MacFJA
Copy link
Owner Author

MacFJA commented Oct 10, 2021

The RediSearch version detection is implemented (since c904606) in:

public static function getRediSearchVersion(ClientInterface $client): ?string

(Usage: $version = \MacFJA\RediSearch\Redis\Initializer::getRediSearchVersion($redisClient))


All Redis commands for RediSearch have a parameter in their constructor to specify the version of RediSearch


High level classes (\MacFJA\RediSearch\Index and \MacFJA\RediSearch\Suggestions) use the version detection internally.


Issue is kept open until the release of the version 2.0.0

@MacFJA MacFJA closed this as completed Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant