Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating a module without update accepts bubbles up incorrectly #14

Open
Macil opened this issue Oct 30, 2015 · 0 comments
Open

Updating a module without update accepts bubbles up incorrectly #14

Macil opened this issue Oct 30, 2015 · 0 comments

Comments

@Macil
Copy link
Owner

Macil commented Oct 30, 2015

Noting this to myself to fix sometime.

If a module without any update accepters gets an update, then the update bubbles up as the system looks to see if its parents might have update accepters, but if we reach an entry script that isn't accepting updates of itself, we should decline the update. Instead, right now the update is incorrectly accepted, and the module and all of its parents all the way up to the entry module are re-executed. This can cause lots of issues (until the user refreshes). This appears as a console message "[HMR] Updated modules" followed by an array of a lot of modules all the way down to the entry script.

Tests for this exist in the "fail" branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant