Prebuild not found for node 10 on windows

[jordao76]

Prebuild not found for node 10, on windows:

> usb-detection@4.3.0 install .\node_modules\usb-detection
> prebuild-install || node-gyp rebuild

prebuild-install WARN install No prebuilt binaries found (target=10.16.0 runtime=node arch=x64 libc= platform=win32)

Originally posted by @jordao76 in #81 (comment)

[MadLittleMods]

From https://nodejs.org/en/download/releases/, I see Node.js v10 is NODE_MODULE_VERSION: 64

I see the build succeeded but no v64 binaries listed on that tag

Looking at the specific build for Node.js v10, I see it installs Node.js v10 but it looks like something is unspecified and it builds against Node.js 4.0.0 instead.

npm : prebuild info begin Prebuild version 8.0.1
At line:2 char:3
+   npm run prebuild
+   ~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (prebuild info b...d version 8.0.1:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError
 
prebuild
 
info
 
build
 Preparing to prebuild usb-detection@4.3.0 for node 4.0.0 on win32-x64 using node-gyp
prebuild
 
verb
 
starting build process node-gyp
 
prebuild
 
verb
 
execute node-gyp with `node index.js rebuild --target=4.0.0 --target_arch=x64 --build_v8_with_gn=false`

Pull request welcome if someone wants to look more into it

[jordao76]

Prebuild uses node-abi for target resolution.

I do see node 4.0.0 for ABI 64 for the electron runtime here: https://github.com/lgeiger/node-abi/blob/master/index.js#L69.

Node 10.0.0, ABI 64 for the node runtime here: https://github.com/lgeiger/node-abi/blob/master/index.js#L57

Prebuild seems to be building for the wrong runtime, electron instead of node. Seems like an issue with prebuild.

[todbot]

There was a bunch of problems around the time of Node v10 and Electron v3 wrt it not reporting to node-abi the right ABI version. The solution seemed to be "don't use Node v10".

[MadLittleMods]

On the latest v4.8.0, I see v64 builds https://github.com/MadLittleMods/node-usb-detection/releases which corresponds to Node.js v10.

Related context behind the update: #106

@jordao76 @todbot Does the latest v4.8.0 fix your issue?

[jordao76]

Tried v4.8.0 with node v12.14.1 and it works. Sorry I won't be able to test with node 10.