Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipenv-setup check fails to handle [extras] #44

Open
lwinkler-cloudflight opened this issue Jan 27, 2021 · 4 comments
Open

pipenv-setup check fails to handle [extras] #44

lwinkler-cloudflight opened this issue Jan 27, 2021 · 4 comments

Comments

@lwinkler-cloudflight
Copy link

Minimal example: hopefully enough to follow as it is an extract from a larger project.

Pipfile

[[source]]
url = "https://pypi.python.org/simple"
verify_ssl = true
name = "pypi"

[packages]
uvicorn = {extras = [ "standard",]}

pipenv-setup generates:

        "uvicorn[standard]==0.13.3",

however:

pipenv-setup check
package 'uvicorn' in pipfile but not in install_requires

expected behaviour:
check can find the translated dependency.

@shaybensasson
Copy link
Contributor

Hi,
I solved this issue and followed the contributing guide ... then, tried to add a pull request but I don't have permission to do so.
Hope the creator of this repo will contact me.
And maybe I'm just doing something wrong (created a branch after cloning, then when I try to push the branch to create a pull request, I get access denied)

@bryant-finney
Copy link
Collaborator

Hi @shaybensasson ,

I would advise creating the PR from a fork of this repo (as described here)

@jshwi
Copy link
Contributor

jshwi commented Nov 22, 2021

@shaybensasson

this looks like a quick-win, I was considering looking into this but if you have found a fix please push a PR from your fork! 😄

@shaybensasson
Copy link
Contributor

#94 Here you go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants