Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve comments #91

Open
jshwi opened this issue Nov 29, 2021 · 3 comments
Open

Preserve comments #91

jshwi opened this issue Nov 29, 2021 · 3 comments

Comments

@jshwi
Copy link
Contributor

jshwi commented Nov 29, 2021

This might be worthwhile looking into

Before pipenv-setup sync --pipfile

setup(
    ...
    include_package_data=True,
    zip_safe=False,
    install_requires=[
        "appdirs>=1.4.4, <=2.0.0",
        # appears the version needs to be strictly specified in order
        # for `pipenv` to allow locking without the additional argument
        "black==21.7b0",
        ...
    ],
    ...
)

After pipenv-setup sync --pipfile

setup(
    ...
    include_package_data=True,
    zip_safe=False,
    install_requires=[
        "appdirs>=1.4.4, <=2.0.0",
        "black==21.7b0",
        ...
    ],
    ...
)
@jshwi
Copy link
Contributor Author

jshwi commented Nov 30, 2021

@bryant-finney I might look at the options for this if you think it's worth perusing.

@bryant-finney
Copy link
Collaborator

@jshwi haha I actually remember bumping into this idiosyncrasy a while back. Seems like a useful fix to me!

@jshwi
Copy link
Contributor Author

jshwi commented Dec 1, 2021

@bryant-finney Awesome, I'll have a look at it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants